mos_layout/

lib.rs

//! Layout engine for Mosaic.
//!
//! Walks a lowered [`Document`] into a [`PageGraph`] with greedy
//! line-breaking: paper size and margins from `#set page(...)`, Base-14
//! metrics for the core fonts, and the bundled Noto Sans shaped through
//! `rustybuzz` for glyphs they lack. Knuth-Plass, hyphenation, and
//! boundary-state reuse for incremental builds (§22.1, §22.3, §33) are
//! out of scope here.

#![doc(
    html_logo_url = "https://mosaiclang.dev/assets/A4.svg",
    html_favicon_url = "https://mosaiclang.dev/assets/A4.svg"
)]

pub use boundary::{PageBoundarySignature, PageGraphSignature};
use mos_fonts::nfc_text;
pub use mos_fonts::{
    Base14Font, EmbeddedFontId, Font, FontFamily, ShapedGlyph, WordSubRun, ascent, descent,
    glyph_width, shape_with_fallback, text_width,
};
pub use style::paper_size_pt;
pub use types::{
    A4_HEIGHT_PT, A4_WIDTH_PT, ImageHandle, ImagePlacement, LayoutResult, MARGIN_PT, OutlineEntry,
    Page, PageGraph, PageStyle, TextRun, TextStyle,
};

use std::collections::BTreeMap;

use mos_core::{AttrValue, Diagnostic, Document, Node, NodeKind};
use style::resolve_styles;
use support::{blank_page, expand_tabs, read_level, read_str_attr};
use types::BODY_LEADING;
use word::{ShyBreak, Word, WordItem, split_soft_hyphens, try_shy_break, word_clusters};

#[doc(hidden)]
pub mod bibliography;
#[doc(hidden)]
pub mod boundary;
pub mod debug;
#[doc(hidden)]
pub mod image;
#[doc(hidden)]
pub mod list;
#[doc(hidden)]
pub mod style;
#[doc(hidden)]
pub mod support;
#[doc(hidden)]
pub mod types;
#[doc(hidden)]
pub mod word;

/// Heading sizes by level (1-indexed). Anything beyond level 3 falls
/// back to body size: counters and section numbering land in MVP 1.
const HEADING_SIZES_PT: [f32; 3] = [20.0, 16.0, 13.0];
/// Space above each heading level (skipped for the first block on a
/// page).
const HEADING_SPACE_BEFORE_PT: [f32; 3] = [16.0, 12.0, 10.0];
/// Space below each heading level.
const HEADING_SPACE_AFTER_PT: [f32; 3] = [10.0, 8.0, 6.0];
/// Vertical gap between consecutive paragraphs.
const PARA_SPACE_AFTER_PT: f32 = 4.0;
/// Horizontal gutter reserved for the list marker (`•` for unordered,
/// `1.` for ordered) on each nesting level. Doubles as the per-level
/// indent step: nested items shift right by this many points before
/// their own gutter is added. Sized to comfortably hold a one- or
/// two-digit ordered marker at the default body size; lists with three-
/// digit numbering will overflow the gutter visually until per-list
/// gutter tuning lands.
const LIST_MARKER_GUTTER_PT: f32 = 18.0;
/// Number of columns represented by one tab in raw code/pre blocks.
const RAW_BLOCK_TAB_WIDTH: usize = 4;

/// The driver for MVP 0 layout.
///
/// # Examples
///
/// ```
/// use mos_layout::LayoutEngine;
///
/// let engine = LayoutEngine::new();
///
/// assert_eq!(format!("{engine:?}"), "LayoutEngine");
/// ```
#[derive(Copy, Clone, Debug, Default)]
pub struct LayoutEngine;

impl LayoutEngine {
    /// Construct a layout engine.
    ///
    /// # Examples
    ///
    /// ```
    /// use mos_layout::LayoutEngine;
    ///
    /// let engine = LayoutEngine::new();
    ///
    /// assert_eq!(format!("{engine:?}"), "LayoutEngine");
    /// ```
    #[must_use]
    pub const fn new() -> Self {
        Self
    }

    /// Lay out `document` into a [`PageGraph`]. Never returns an
    /// error in MVP 0: invalid blocks are skipped and surfaced as
    /// diagnostics on `LayoutResult` instead.
    ///
    /// # Examples
    ///
    /// ```
    /// use std::path::PathBuf;
    ///
    /// use mos_core::Document;
    /// use mos_layout::LayoutEngine;
    ///
    /// let doc = Document::new(PathBuf::from("main.mos"));
    /// let result = LayoutEngine::new().layout(&doc);
    ///
    /// assert_eq!(result.graph.pages.len(), 1);
    /// ```
    #[must_use]
    pub fn layout(self, document: &Document) -> LayoutResult {
        self.layout_impl(document, false)
    }

    /// Lay out a document while recording final geometry and source blocks.
    /// The report is returned alongside the ordinary graph and diagnostics.
    #[must_use]
    pub fn layout_with_debug(self, document: &Document) -> LayoutResult {
        self.layout_impl(document, true)
    }

    fn layout_impl(self, document: &Document, capture_debug: bool) -> LayoutResult {
        let Self = self;
        let (page_style, text_style, mut diagnostics) = resolve_styles(document);
        let mut state = LayoutState::new(page_style, text_style);
        if capture_debug {
            state.debug = Some(debug::Recorder::default());
        }
        state.diagnostics.append(&mut diagnostics);
        let Some(root) = document.get(document.root) else {
            return state.finish();
        };
        for child_id in &root.children {
            let Some(node) = document.get(*child_id) else {
                continue;
            };
            // Queue this block's label (if any) so it binds to the page its
            // first content actually lands on (issue #72), not the page the
            // cursor happens to sit on before a break.
            state.queue_label(node);
            state.begin_debug_block(node);
            match node.kind {
                NodeKind::Section => state.layout_heading(document, node),
                NodeKind::Paragraph => state.layout_paragraph(document, node),
                NodeKind::Image => state.layout_image(*child_id, node),
                NodeKind::Figure => state.layout_figure(document, node),
                NodeKind::List => state.layout_list(document, node),
                NodeKind::Bibliography => state.layout_bibliography(document, node),
                NodeKind::Raw if node.attributes.contains_key("raw.kind") => {
                    state.layout_raw_block(node);
                }
                // `#set` blocks are stashed as `Raw` children of the
                // root; folded into styles by `resolve_styles` above.
                NodeKind::Raw if node.attributes.contains_key("set") => {}
                _ => {
                    // Unknown top-level kinds (Table, Equation, etc.)
                    // arrive in MVP 1+; ignore so MVP 0 doesn't panic
                    // on forward-compatible input.
                }
            }
            // This block is fully laid out. Any label still queued belongs to a
            // block that emitted no content (an empty paragraph, an unsupported
            // kind, a `#set` block); drop it so it never binds to a later
            // block's page (issue #72).
            state.discard_unbound_labels();
            state.end_debug_block();
        }
        state.finish()
    }
}

/// Mutable cursor + accumulator threaded through the layout.
struct LayoutState {
    debug: Option<debug::Recorder>,
    pages: Vec<Page>,
    /// In-progress page being filled.
    current_page: Page,
    /// Y position of the next baseline, measured from page top.
    cursor_y: f32,
    /// Whether `current_page` has had any block emitted yet (controls
    /// `space_before` skipping).
    page_has_content: bool,
    diagnostics: Vec<Diagnostic>,
    page: PageStyle,
    text: TextStyle,
    /// Image dedup table: resolved path → handle. Two `#image(...)`
    /// directives that reference the same on-disk file share one
    /// [`ImageHandle`] (and therefore one `XObject` in the emitted PDF).
    image_handles: Vec<ImageHandle>,
    /// Left edge of the current text column. Equals `page.margin`
    /// at the top level; list layout pushes this rightward so item
    /// text hangs into the gutter under its marker.
    current_left_pt: f32,
    /// Marker run to emit at the start of the next flushed line. Used
    /// by list items to draw `•` / `1.` in the gutter to the left of
    /// `current_left_pt` on the first line of each item. Cleared by
    /// `flush_line` once the marker is committed to a page.
    pending_marker: Option<PendingMarker>,
    /// Labels of blocks dispatched but not yet committed to a page. Bound
    /// to the page their first content lands on (issue #72): see
    /// [`LayoutState::bind_pending_labels`].
    pending_labels: Vec<String>,
    /// Built result of label → 1-based start page. Emitted into the
    /// [`PageGraph`] by [`LayoutState::finish`].
    label_pages: BTreeMap<String, u32>,
    /// Heading captured in `layout_heading` but not yet committed to a
    /// page. Bound to the page (and glyph-top y) of the heading's first
    /// flushed line by [`LayoutState::bind_pending_outline`], mirroring
    /// the pending-label flow.
    pending_outline: Option<PendingOutline>,
    /// Bookmark/outline entries in document order. Emitted into the
    /// [`PageGraph`] by [`LayoutState::finish`].
    outline: Vec<OutlineEntry>,
}

#[derive(Clone, Debug)]
struct PendingOutline {
    level: u8,
    title: String,
}

#[derive(Clone, Debug)]
struct PendingMarker {
    /// X position (page-relative, points from the page's left edge)
    /// where the marker's left edge should sit.
    x_pt: f32,
    /// Pre-shaped marker word. Width is informational only: the
    /// marker is drawn outside `current_left_pt` so it doesn't reserve
    /// space in the text column.
    word: Word,
}

#[derive(Clone, Copy, Debug)]
struct PendingSpace {
    width_pt: f32,
    from_line_break: bool,
}

impl LayoutState {
    const fn new(page: PageStyle, text: TextStyle) -> Self {
        Self {
            debug: None,
            pages: Vec::new(),
            current_page: blank_page(1, page),
            cursor_y: page.margin,
            page_has_content: false,
            diagnostics: Vec::new(),
            page,
            text,
            image_handles: Vec::new(),
            current_left_pt: page.margin,
            pending_marker: None,
            pending_labels: Vec::new(),
            label_pages: BTreeMap::new(),
            pending_outline: None,
            outline: Vec::new(),
        }
    }

    /// Queue a block's `label` attribute (if present) for binding to the
    /// page its first content commits to (issue #72).
    fn queue_label(&mut self, node: &Node) {
        if let Some(AttrValue::Str(label)) = node.attributes.get("label") {
            self.pending_labels.push(label.clone());
        }
    }

    /// Drop labels still queued after a block finished laying out. The block
    /// (or its label) committed no content, so the label has no page; clearing
    /// it keeps a labelled no-content block out of `label_pages` instead of
    /// letting its label leak onto the next block that does emit content. Only
    /// the just-dispatched block's label can be queued here, since
    /// [`queue_label`](Self::queue_label) runs once per top-level block.
    fn discard_unbound_labels(&mut self) {
        self.pending_labels.clear();
    }

    /// Bind every queued label to the current page. Called at each
    /// first-content-commit site *after* its page-break check, so a label
    /// maps to where its target actually lands. First placement wins
    /// (`or_insert`), matching the resolver's first-occurrence label rule.
    fn bind_pending_labels(&mut self) {
        if self.pending_labels.is_empty() {
            return;
        }
        let page = self.current_page.number;
        for label in self.pending_labels.drain(..) {
            self.label_pages.entry(label).or_insert(page);
        }
    }

    /// Bind a pending heading to the current page as an outline entry.
    /// Called from `flush_line` after the page break check, so a heading
    /// whose first line spills to the next page records that page. Cleared
    /// on push so only the heading's first flushed line binds; wrapped
    /// continuation lines of the same heading don't restamp it.
    fn bind_pending_outline(&mut self, top_from_top_pt: f32) {
        let Some(pending) = self.pending_outline.take() else {
            return;
        };
        // `current_page.number` is 1-based; the PDF backend wants a
        // 0-based index into `PageGraph::pages`, which is populated in
        // page order, so page N is at index N-1.
        let page_index = usize::try_from(self.current_page.number.saturating_sub(1)).unwrap_or(0);
        self.outline.push(OutlineEntry {
            level: pending.level,
            title: pending.title,
            page_index,
            top_from_top_pt,
        });
    }

    fn column_width_pt(&self) -> f32 {
        self.page.width - self.page.margin - self.current_left_pt
    }

    fn finish(mut self) -> LayoutResult {
        // Always emit the last page even if empty so the PDF is valid
        // (a Pages tree with `Count 0` is illegal); only skip when an
        // earlier page already accumulated content and the trailing
        // page is genuinely blank.
        if self.page_has_content || self.pages.is_empty() {
            self.pages.push(self.current_page);
        }
        let debug = self.debug.map(|trace| trace.finish(&self.pages, self.page));
        LayoutResult {
            graph: PageGraph {
                pages: self.pages,
                images: self.image_handles,
                outline: self.outline,
            },
            diagnostics: self.diagnostics,
            debug,
            label_pages: self.label_pages,
        }
    }

    fn begin_debug_block(&mut self, node: &Node) {
        if let Some(trace) = &mut self.debug {
            trace.begin_block(node);
        }
    }

    fn end_debug_block(&mut self) {
        if let Some(trace) = &mut self.debug {
            trace.end_block();
        }
    }

    fn push_text_run(&mut self, run: TextRun, advance_pt: f32) {
        if let Some(trace) = &mut self.debug {
            trace.run(self.current_page.runs.len(), &run, advance_pt);
        }
        self.current_page.runs.push(run);
    }

    fn layout_heading(&mut self, document: &Document, section: &Node) {
        let heading_level = read_level(section).unwrap_or(1).clamp(1, 3);
        let level = usize::from(heading_level);
        let size = HEADING_SIZES_PT[level - 1];
        let space_before = HEADING_SPACE_BEFORE_PT[level - 1];
        let space_after = HEADING_SPACE_AFTER_PT[level - 1];

        if self.page_has_content {
            self.cursor_y += space_before;
        }
        let bold = self.text.family.bold;
        let mut words = self.collect_words(document, section, bold, size);
        // Capture the bookmark/outline entry from the freshly-collected
        // words, BEFORE the number prefix is inserted below: the title
        // is composed as "<number> <text>" explicitly, so re-using the
        // prefixed word stream would double the number (and its trailing
        // dot). Skip no-text headings, mirroring the label behavior.
        let title_text = words
            .iter()
            .filter_map(|item| match item {
                WordItem::Word(w) => Some(w.text.as_str()),
                WordItem::HardBreak => None,
            })
            .collect::<Vec<_>>()
            .join(" ");
        if !title_text.is_empty() {
            let title = match read_str_attr(section, "number") {
                Some(number) => format!("{number} {title_text}"),
                None => title_text,
            };
            self.pending_outline = Some(PendingOutline {
                level: heading_level,
                title,
            });
        }
        // Resolver-assigned section number is rendered as a leading
        // word so it gets the same font/size as the title and flows
        // through the existing line-break path. The trailing `.` is
        // the conventional "1." style; `#set heading(numbering: ...)`
        // (manifest §4) overrides it once `#set` is interpreted.
        if let Some(number) = read_str_attr(section, "number") {
            let prefix = format!("{number}.");
            let subruns = shape_with_fallback(bold, self.text.family.fallbacks, size, &prefix);
            let width_pt: f32 = subruns.iter().map(|s| s.advance_pt).sum();
            words.insert(
                0,
                WordItem::Word(Word {
                    text: prefix,
                    actual_text: None,
                    space_before_pt: 0.0,
                    font: bold,
                    size_pt: size,
                    width_pt,
                    subruns,
                    shy_break_offsets: Vec::new(),
                }),
            );
            if let Some(WordItem::Word(first_title_word)) = words.get_mut(1)
                && first_title_word.space_before_pt <= f32::EPSILON
            {
                first_title_word.space_before_pt = text_width(bold, size, " ");
            }
        }
        self.flow_words(&words, BODY_LEADING);
        self.cursor_y += space_after;
    }

    fn layout_paragraph(&mut self, document: &Document, paragraph: &Node) {
        let size = self.text.size_pt;
        let leading = self.text.leading;
        let regular = self.text.family.regular;
        let words = self.collect_words(document, paragraph, regular, size);
        self.flow_words(&words, leading);
        self.cursor_y += PARA_SPACE_AFTER_PT;
    }

    fn layout_raw_block(&mut self, raw: &Node) {
        let Some(AttrValue::Str(text)) = raw.attributes.get("text") else {
            return;
        };
        let size = self.text.size_pt;
        let leading = self.text.leading;
        let font = self.text.family.monospace;
        let mut emitted = false;
        for line in text.lines() {
            if line.is_empty() {
                if !self.page_has_content {
                    self.cursor_y = self.page.margin + ascent(font, size);
                    self.page_has_content = true;
                }
                self.cursor_y = size.mul_add(leading, self.cursor_y);
                continue;
            }
            let expanded_line = expand_tabs(line, RAW_BLOCK_TAB_WIDTH);
            let subruns = shape_with_fallback(
                font,
                self.text.family.fallbacks,
                size,
                expanded_line.as_ref(),
            );
            let width_pt: f32 = subruns.iter().map(|s| s.advance_pt).sum();
            let actual_text = (expanded_line.as_ref() != line).then(|| line.to_owned());
            let word = Word {
                text: expanded_line.into_owned(),
                actual_text,
                space_before_pt: 0.0,
                font,
                size_pt: size,
                width_pt,
                subruns,
                shy_break_offsets: Vec::new(),
            };
            self.flow_words(&[WordItem::Word(word)], leading);
            emitted = true;
        }
        if emitted {
            self.cursor_y += PARA_SPACE_AFTER_PT;
        }
    }

    /// Walk `parent`'s inline children and produce a flat list of
    /// [`WordItem`]s. Source ASCII whitespace becomes explicit collapsed
    /// glue on the following word; inline style/font boundaries alone
    /// produce no glue and no break opportunity. A source line wrap before
    /// closing punctuation is formatting only and attaches to the previous
    /// word. U+00A0 NBSP is intentionally preserved inside the word. Each
    /// visible fragment is shaped once here, and no-source-space fragments
    /// merge into one unbreakable layout word even when their fonts differ.
    fn collect_words(
        &self,
        document: &Document,
        parent: &Node,
        default_font: Font,
        size: f32,
    ) -> Vec<WordItem> {
        let mut out: Vec<WordItem> = Vec::new();
        let mut current_word: Option<Word> = None;
        let mut pending_space: Option<PendingSpace> = None;
        for child_id in &parent.children {
            let Some(child) = document.get(*child_id) else {
                continue;
            };
            if matches!(child.kind, NodeKind::HardBreak) {
                Self::flush_pending_word(&mut current_word, &mut out);
                out.push(WordItem::HardBreak);
                pending_space = None;
                continue;
            }
            let font = match child.kind {
                NodeKind::Strong => self.text.family.bold,
                NodeKind::Emphasis => self.text.family.italic,
                NodeKind::BoldItalic => self.text.family.bold_italic,
                NodeKind::Raw => self.text.family.monospace,
                // Nested list blocks under a `ListItem` are laid out
                // separately by `layout_list`; skip them here so they
                // don't leak into the parent item's word stream.
                NodeKind::List | NodeKind::ListItem => continue,
                _ => default_font,
            };
            let raw = match child.attributes.get("text") {
                Some(AttrValue::Str(s)) => s.as_str(),
                _ => continue,
            };
            self.collect_text_words(
                raw,
                font,
                size,
                &mut current_word,
                &mut pending_space,
                &mut out,
            );
        }
        Self::flush_pending_word(&mut current_word, &mut out);
        out
    }

    fn collect_text_words(
        &self,
        raw: &str,
        font: Font,
        size: f32,
        current_word: &mut Option<Word>,
        pending_space: &mut Option<PendingSpace>,
        out: &mut Vec<WordItem>,
    ) {
        let mut word_start: Option<usize> = None;
        for (idx, ch) in raw.char_indices() {
            if ch.is_ascii_whitespace() {
                if let Some(start) = word_start.take() {
                    self.append_word_piece(
                        &raw[start..idx],
                        font,
                        size,
                        current_word,
                        pending_space,
                        out,
                    );
                }
                let from_line_break = matches!(ch, '\n' | '\r');
                let width_pt = text_width(font, size, " ");
                if let Some(space) = pending_space {
                    space.width_pt = width_pt;
                    space.from_line_break |= from_line_break;
                } else {
                    *pending_space = Some(PendingSpace {
                        width_pt,
                        from_line_break,
                    });
                }
            } else if word_start.is_none() {
                word_start = Some(idx);
            }
        }
        if let Some(start) = word_start {
            self.append_word_piece(&raw[start..], font, size, current_word, pending_space, out);
        }
    }

    fn append_word_piece(
        &self,
        piece: &str,
        font: Font,
        size: f32,
        current_word: &mut Option<Word>,
        pending_space: &mut Option<PendingSpace>,
        out: &mut Vec<WordItem>,
    ) {
        let piece = nfc_text(piece);
        let piece = piece.as_ref();
        // Strip U+00AD before shaping so SHY never renders as a visible
        // hyphen on either the embedded or Base-14 path. Offsets remain
        // attached to the merged layout word for the current greedy SHY
        // breaker and later Knuth-Plass penalties.
        let (stripped, shy_offsets) = split_soft_hyphens(piece);
        if stripped.is_empty() {
            if pending_space.is_none()
                && let Some(word) = current_word
            {
                let offset = word.text.len();
                word.shy_break_offsets
                    .extend(shy_offsets.into_iter().map(|idx| offset + idx));
            }
            return;
        }
        let subruns = shape_with_fallback(font, self.text.family.fallbacks, size, &stripped);
        let width_pt: f32 = subruns.iter().map(|s| s.advance_pt).sum();
        if let Some(space) = pending_space.take() {
            if space.from_line_break && starts_with_closing_punctuation(&stripped) {
                Self::append_to_current_word(
                    current_word,
                    stripped,
                    font,
                    size,
                    width_pt,
                    subruns,
                    shy_offsets,
                );
                return;
            }
            Self::flush_pending_word(current_word, out);
            *current_word = Some(Word {
                text: stripped,
                actual_text: None,
                space_before_pt: space.width_pt,
                font,
                size_pt: size,
                width_pt,
                subruns,
                shy_break_offsets: shy_offsets,
            });
            return;
        }
        Self::append_to_current_word(
            current_word,
            stripped,
            font,
            size,
            width_pt,
            subruns,
            shy_offsets,
        );
    }

    fn append_to_current_word(
        current_word: &mut Option<Word>,
        text: String,
        font: Font,
        size: f32,
        width_pt: f32,
        subruns: Vec<WordSubRun>,
        shy_offsets: Vec<usize>,
    ) {
        if let Some(word) = current_word {
            let offset = word.text.len();
            word.text.push_str(&text);
            word.width_pt += width_pt;
            word.subruns.extend(subruns);
            word.shy_break_offsets
                .extend(shy_offsets.into_iter().map(|idx| offset + idx));
            return;
        }
        *current_word = Some(Word {
            text,
            actual_text: None,
            space_before_pt: 0.0,
            font,
            size_pt: size,
            width_pt,
            subruns,
            shy_break_offsets: shy_offsets,
        });
    }

    fn flush_pending_word(current_word: &mut Option<Word>, out: &mut Vec<WordItem>) {
        if let Some(word) = current_word.take() {
            out.push(WordItem::Word(word));
        }
    }

    /// Greedy line-break `items` and emit text runs onto the page,
    /// paginating as we go. `leading` is the line-height multiplier
    /// applied per line. `WordItem::HardBreak` forces a line flush
    /// at its position (and produces a blank line when two hard
    /// breaks are adjacent or one lands mid-paragraph with no words
    /// behind it).
    fn flow_words(&mut self, items: &[WordItem], leading: f32) {
        if items.is_empty() {
            return;
        }
        let line_width = self.column_width_pt();
        let mut line: Vec<Word> = Vec::new();
        let mut line_width_used = 0.0_f32;
        // Paragraph-local state so hard-break collapsing follows
        // block-boundary semantics rather than page-state ones:
        // * `paragraph_emitted_line` is true once anything in this
        //   paragraph has emitted vertical space (a flushed line, a
        //   wrapped overflow, or an oversize chunk).
        // * `last_was_hardbreak_flush` is true only after a hard
        //   break flushed (or stacked onto) a line. Stacked hard
        //   breaks emit blank lines; a hard break following an
        //   implicit break (oversize / soft wrap) is absorbed without
        //   adding a blank line, matching the author's natural
        //   reading of "force a break here" when the line just
        //   ended on its own.
        let mut paragraph_emitted_line = false;
        let mut last_was_hardbreak_flush = false;
        // Suffix produced by a SHY split takes priority over the
        // next `items` entry. A single source word with several SHYs
        // may break twice (`super\-cali\-fragil\-istic` on a narrow
        // column), so the suffix re-enters the same dispatch loop.
        let mut pending: Option<Word> = None;
        let mut item_idx = 0;

        loop {
            let word_owned: Word = if let Some(w) = pending.take() {
                w
            } else if item_idx < items.len() {
                let item = &items[item_idx];
                item_idx += 1;
                match item {
                    WordItem::Word(w) => w.clone(),
                    WordItem::HardBreak => {
                        if !line.is_empty() {
                            self.flush_line(&line, leading);
                            line.clear();
                            line_width_used = 0.0;
                            paragraph_emitted_line = true;
                            last_was_hardbreak_flush = true;
                        } else if last_was_hardbreak_flush {
                            // Stacked hard breaks: emit a blank line
                            // and remain in the "just hard-broke"
                            // state so a third break emits another
                            // blank.
                            self.cursor_y = self.text.size_pt.mul_add(leading, self.cursor_y);
                        } else if paragraph_emitted_line {
                            // First hard break after an implicit
                            // break (oversize chunk or soft-wrap
                            // flush). The cursor already advanced
                            // past the previous line, so this break
                            // is absorbed silently. Promote the
                            // state so a *second* stacked hard
                            // break still produces a blank line.
                            last_was_hardbreak_flush = true;
                        }
                        // else: paragraph hasn't emitted anything
                        // yet -- leading hard breaks collapse
                        // silently regardless of whether prior
                        // blocks have painted on the page.
                        continue;
                    }
                }
            } else {
                break;
            };

            let space_w = if line.is_empty() {
                0.0
            } else {
                word_owned.space_before_pt
            };

            // Word fits on the current line: append and continue.
            if line_width_used + space_w + word_owned.width_pt <= line_width {
                line_width_used += space_w + word_owned.width_pt;
                line.push(word_owned);
                continue;
            }

            if !line.is_empty() && space_w <= f32::EPSILON {
                line_width_used += word_owned.width_pt;
                line.push(word_owned);
                continue;
            }

            // Word does not fit. First try a SHY break that lets us
            // keep filling the current partially-occupied line.
            if !line.is_empty()
                && let Some(ShyBreak { prefix, suffix }) = try_shy_break(
                    &word_owned,
                    line_width - line_width_used - space_w,
                    self.text.family.fallbacks,
                )
            {
                line.push(prefix);
                self.flush_line(&line, leading);
                line.clear();
                line_width_used = 0.0;
                paragraph_emitted_line = true;
                last_was_hardbreak_flush = false;
                pending = Some(suffix);
                continue;
            }

            // Either no SHY fit the current line, or the line was
            // already empty. Flush any in-progress line and decide
            // what to do on a fresh empty line.
            if !line.is_empty() {
                self.flush_line(&line, leading);
                line.clear();
                line_width_used = 0.0;
                paragraph_emitted_line = true;
                last_was_hardbreak_flush = false;
            }

            // On the now-empty line: if the word still doesn't fit
            // the full column, try a SHY break against the empty
            // line before falling back to cluster chopping.
            if word_owned.width_pt > line_width {
                if let Some(ShyBreak { prefix, suffix }) =
                    try_shy_break(&word_owned, line_width, self.text.family.fallbacks)
                {
                    line.push(prefix);
                    self.flush_line(&line, leading);
                    line.clear();
                    line_width_used = 0.0;
                    paragraph_emitted_line = true;
                    last_was_hardbreak_flush = false;
                    pending = Some(suffix);
                    continue;
                }
                self.flush_oversize_word(&word_owned, leading);
                paragraph_emitted_line = true;
                last_was_hardbreak_flush = false;
                continue;
            }

            // Word fits the empty line as-is (a plain soft wrap).
            line_width_used = word_owned.width_pt;
            line.push(word_owned);
        }
        if !line.is_empty() {
            self.flush_line(&line, leading);
        }
    }

    /// Emit one line worth of words at `cursor_y`, advancing past it.
    /// Computes the line's typographic metrics from `line` itself so
    /// the caller doesn't have to track them in parallel.
    fn flush_line(&mut self, line: &[Word], leading: f32) {
        // The marker participates in the line's vertical metrics so a
        // taller marker still gets the right baseline. In practice the
        // marker uses the body face at body size, but folding it in
        // costs nothing and avoids surprises if list layout grows the
        // ability to override marker size later.
        let marker_size = self
            .pending_marker
            .as_ref()
            .map_or(0.0_f32, |m| m.word.size_pt);
        let marker_ascent = self.pending_marker.as_ref().map_or(0.0_f32, |m| {
            m.word
                .subruns
                .iter()
                .map(|sub| ascent(sub.font, m.word.size_pt))
                .fold(0.0_f32, f32::max)
        });
        let max_size = line.iter().map(|w| w.size_pt).fold(marker_size, f32::max);
        let max_ascent = line
            .iter()
            .flat_map(|w| w.subruns.iter().map(|sub| ascent(sub.font, w.size_pt)))
            .fold(marker_ascent, f32::max);

        // First line on a page: drop the baseline by the line's
        // ascent so the glyph tops sit at the top margin.
        if !self.page_has_content {
            self.cursor_y = self.page.margin + max_ascent;
        }
        // Page break if the baseline would fall below the bottom
        // margin. Descent is small and absorbed by the bottom margin.
        if self.cursor_y > self.page.height - self.page.margin {
            self.start_new_page();
            self.cursor_y = self.page.margin + max_ascent;
        }

        // The page is now settled for this line; bind any labels waiting on
        // their first content to it (issue #72).
        self.bind_pending_labels();
        // A pending heading binds to this line too: `cursor_y` is the
        // just-locked baseline, so `cursor_y - max_ascent` is the glyph
        // tops measured from the page top (the outline destination).
        self.bind_pending_outline(self.cursor_y - max_ascent);

        // Marker (`•` / `1.` …) is drawn in the gutter to the left of
        // `current_left_pt` once the baseline is locked. Consumed on
        // emit so subsequent wrapped lines of the same item don't
        // restamp the marker.
        if let Some(marker) = self.pending_marker.take() {
            let mut marker_x = marker.x_pt;
            for sub in marker.word.subruns {
                self.push_text_run(
                    TextRun {
                        x_pt: marker_x,
                        baseline_from_top_pt: self.cursor_y,
                        size_pt: marker.word.size_pt,
                        font: sub.font,
                        text: sub.text,
                        actual_text: None,
                        glyphs: sub.glyphs,
                    },
                    sub.advance_pt,
                );
                marker_x += sub.advance_pt;
            }
        }

        let mut x = self.current_left_pt;
        for (i, word) in line.iter().enumerate() {
            if i > 0 {
                x += word.space_before_pt;
            }
            // One TextRun per sub-run: same baseline, x advances by
            // each sub-run's `advance_pt`. PDF emit's per-run `Tf`
            // switch fires naturally at the font boundary between
            // sub-runs (Latin → Math → Latin in `a≤b`-style runs).
            for sub in &word.subruns {
                self.push_text_run(
                    TextRun {
                        x_pt: x,
                        baseline_from_top_pt: self.cursor_y,
                        size_pt: word.size_pt,
                        font: sub.font,
                        text: sub.text.clone(),
                        actual_text: word.actual_text.clone(),
                        glyphs: sub.glyphs.clone(),
                    },
                    sub.advance_pt,
                );
                x += sub.advance_pt;
            }
        }
        if let Some(trace) = &mut self.debug {
            trace.line(self.current_page.number, self.cursor_y);
        }
        self.page_has_content = true;
        self.cursor_y = max_size.mul_add(leading, self.cursor_y);
    }

    /// Emit a word that's wider than the column by chopping it on
    /// already-shaped cluster boundaries. The word was shaped when it
    /// was collected, so this avoids re-running rustybuzz for every
    /// growing prefix of a degenerate long word.
    fn flush_oversize_word(&mut self, word: &Word, leading: f32) {
        let line_width = self.column_width_pt();
        let mut chunk_text = String::with_capacity(word.text.len());
        let mut chunk_width = 0.0_f32;
        let mut chunk_subruns = Vec::new();
        for cluster in word_clusters(word) {
            if chunk_width + cluster.advance_pt > line_width && !chunk_subruns.is_empty() {
                self.flush_oversize_chunk(
                    std::mem::take(&mut chunk_text),
                    chunk_width,
                    std::mem::take(&mut chunk_subruns),
                    word,
                    leading,
                );
                chunk_width = 0.0;
            }
            chunk_text.push_str(&cluster.text);
            chunk_width += cluster.advance_pt;
            chunk_subruns.push(cluster);
        }
        if !chunk_subruns.is_empty() {
            self.flush_oversize_chunk(chunk_text, chunk_width, chunk_subruns, word, leading);
        }
    }

    fn flush_oversize_chunk(
        &mut self,
        text: String,
        width_pt: f32,
        subruns: Vec<WordSubRun>,
        source: &Word,
        leading: f32,
    ) {
        self.flush_line(
            &[Word {
                text,
                actual_text: None,
                space_before_pt: 0.0,
                font: source.font,
                size_pt: source.size_pt,
                width_pt,
                subruns,
                shy_break_offsets: Vec::new(),
            }],
            leading,
        );
    }

    fn start_new_page(&mut self) {
        let next_number = self.current_page.number + 1;
        let finished =
            std::mem::replace(&mut self.current_page, blank_page(next_number, self.page));
        self.pages.push(finished);
        self.cursor_y = self.page.margin;
        self.page_has_content = false;
    }
}

fn starts_with_closing_punctuation(text: &str) -> bool {
    matches!(
        text.chars().next(),
        Some('.' | ',' | ';' | ':' | '!' | '?' | ')' | ']' | '}' | '”' | '’' | '»')
    )
}

#[cfg(test)]
mod tests {
    #![allow(
        clippy::unwrap_used,
        clippy::expect_used,
        reason = "tests panic loudly on setup failure; matches crate-wide test-module convention"
    )]
    use std::fmt::Write as _;
    use std::path::PathBuf;

    use mos_core::{AttrMap, AttrValue, Document, NodeId, NodeKind, NodeSpec, SourceSpan};

    use crate::types::BODY_SIZE_PT;

    use super::*;

    fn alloc_inline(doc: &mut Document, parent: NodeId, kind: NodeKind, text: &str) {
        let mut attrs = AttrMap::new();
        attrs.insert("text".to_owned(), AttrValue::Str(text.to_owned()));
        doc.alloc_child(
            parent,
            NodeSpec::new(kind, SourceSpan::placeholder(PathBuf::from("test.mos")))
                .with_attributes(attrs),
        );
    }

    /// Tests that assert Base14 font variants on `TextRun` need to opt
    /// out of the default Noto Sans family. Prepend a `#set
    /// text(font: "Helvetica")` block so the family resolves to
    /// Base14 Helvetica.
    fn pin_helvetica(doc: &mut Document) {
        let mut attrs = AttrMap::new();
        attrs.insert("set".to_owned(), AttrValue::Str("text".to_owned()));
        attrs.insert(
            "set.arg.font".to_owned(),
            AttrValue::Str("Helvetica".to_owned()),
        );
        doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Raw,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
    }

    fn make_section(doc: &mut Document, level: i64, text: &str) -> NodeId {
        let mut attrs = AttrMap::new();
        attrs.insert("level".to_owned(), AttrValue::Int(level));
        let id = doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Section,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        alloc_inline(doc, id, NodeKind::Text, text);
        id
    }

    fn make_paragraph(doc: &mut Document, text: &str) -> NodeId {
        let id = doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Paragraph,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            ),
        );
        alloc_inline(doc, id, NodeKind::Text, text);
        id
    }

    fn make_labelled_paragraph(doc: &mut Document, text: &str, label: &str) -> NodeId {
        let mut attrs = AttrMap::new();
        attrs.insert("label".to_owned(), AttrValue::Str(label.to_owned()));
        let id = doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Paragraph,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        alloc_inline(doc, id, NodeKind::Text, text);
        id
    }

    fn make_raw_block(doc: &mut Document, text: &str) -> NodeId {
        let mut attrs = AttrMap::new();
        attrs.insert("raw.kind".to_owned(), AttrValue::Str("code".to_owned()));
        attrs.insert("text".to_owned(), AttrValue::Str(text.to_owned()));
        doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Raw,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        )
    }

    fn run_text<'a>(runs: &'a [TextRun], text: &str) -> &'a TextRun {
        runs.iter()
            .find(|run| run.text == text)
            .expect("run text not found")
    }

    fn assert_runs_touch(left: &TextRun, right: &TextRun) {
        assert!(
            (left.baseline_from_top_pt - right.baseline_from_top_pt).abs() < 0.01,
            "runs are on different baselines: left={left:?}, right={right:?}"
        );
        let expected_x = left.x_pt + text_width(left.font, left.size_pt, &left.text);
        assert!(
            (right.x_pt - expected_x).abs() < 0.01,
            "expected {:?} to touch {:?}: expected x {expected_x:.3}, got {:.3}",
            right.text,
            left.text,
            right.x_pt
        );
    }

    #[test]
    fn heading_then_paragraph_emits_runs_in_order() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        make_section(&mut doc, 1, "Hello");
        make_paragraph(&mut doc, "body");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        assert_eq!(result.graph.pages.len(), 1);
        let runs = &result.graph.pages[0].runs;
        assert!(runs.len() >= 2, "expected at least 2 runs, got {runs:?}");
        // Heading first, body below it.
        assert!(matches!(
            runs[0].font,
            Font::Base14(Base14Font::HelveticaBold)
        ));
        assert_eq!(runs[0].text, "Hello");
        let body_run = runs.iter().find(|r| r.text == "body").expect("body run");
        assert!(matches!(body_run.font, Font::Base14(Base14Font::Helvetica)));
        assert!(body_run.baseline_from_top_pt > runs[0].baseline_from_top_pt);
    }

    #[test]
    fn long_paragraph_paginates() {
        // Build a paragraph long enough to spill a second page at
        // body size + leading 1.35.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        // ~150 lines of text at 11pt × 1.35 leading ≈ 2227 pt of
        // copy. A4 minus margins is roughly 706 pt of vertical
        // space, so we expect ≥ 3 pages.
        let mut text = String::new();
        for i in 0..1500 {
            let _ = write!(text, "word{i} ");
        }
        make_paragraph(&mut doc, text.trim());
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.graph.pages.len() >= 2,
            "expected pagination, got {} page(s)",
            result.graph.pages.len()
        );
    }

    #[test]
    fn page_boundary_signatures_are_stable_and_change_with_pagination() {
        fn lay_out(word_count: usize) -> LayoutResult {
            let mut doc = Document::new(PathBuf::from("test.mos"));
            let mut text = String::new();
            for i in 0..word_count {
                let _ = write!(text, "word{i} ");
            }
            make_paragraph(&mut doc, text.trim());
            LayoutEngine::new().layout(&doc)
        }

        // Deterministic for unchanged input: the same document laid out twice
        // signs identically and diverges nowhere.
        let first = lay_out(1500);
        let again = lay_out(1500);
        assert!(first.graph.pages.len() >= 2, "expected a multi-page layout");
        assert_eq!(
            first.page_boundary_signatures(),
            again.page_boundary_signatures(),
        );
        assert_eq!(
            first
                .page_boundary_signatures()
                .first_divergence(&again.page_boundary_signatures()),
            None,
        );

        // Appending copy reflows pagination, so the signatures must diverge at
        // some page.
        let longer = lay_out(1540);
        let base_sig = first.page_boundary_signatures();
        let longer_sig = longer.page_boundary_signatures();
        assert_ne!(base_sig, longer_sig);
        assert!(longer_sig.pages().len() >= base_sig.pages().len());
        assert!(base_sig.first_divergence(&longer_sig).is_some());
    }

    #[test]
    fn label_pages_maps_a_first_block_to_page_one() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_labelled_paragraph(&mut doc, "Introduction", "intro");
        let result = LayoutEngine::new().layout(&doc);
        assert_eq!(result.label_pages.get("intro").copied(), Some(1));
    }

    #[test]
    fn label_pages_records_the_start_page_after_a_break() {
        // A page-filling paragraph, then a labelled paragraph with a unique
        // word. The label must bind to the page its content actually lands on
        // (post-break), not the page the cursor sat on before the break.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        let mut filler = String::new();
        for i in 0..1500 {
            let _ = write!(filler, "word{i} ");
        }
        make_paragraph(&mut doc, filler.trim());
        make_labelled_paragraph(&mut doc, "ZZUNIQUE", "tail");

        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.graph.pages.len() >= 2,
            "expected a multi-page layout"
        );

        let recorded = result.label_pages.get("tail").copied();
        // Cross-check: the recorded page is exactly the page whose runs contain
        // the labelled paragraph's text.
        let actual = result
            .graph
            .pages
            .iter()
            .find(|page| page.runs.iter().any(|run| run.text == "ZZUNIQUE"))
            .map(|page| page.number);
        assert_eq!(recorded, actual);
        assert!(recorded.is_some_and(|page| page >= 2), "{recorded:?}");
    }

    #[test]
    fn label_pages_omits_unlabelled_blocks_and_keeps_first_occurrence() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "unlabelled");
        make_labelled_paragraph(&mut doc, "first", "dup");
        make_labelled_paragraph(&mut doc, "second", "dup");
        let result = LayoutEngine::new().layout(&doc);
        // One entry per distinct label; the unlabelled block contributes none.
        assert_eq!(result.label_pages.len(), 1);
        assert_eq!(result.label_pages.get("dup").copied(), Some(1));
    }

    #[test]
    fn label_pages_omits_a_labelled_block_that_emits_no_content() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        // A labelled empty paragraph commits no content (no words to flush)...
        make_labelled_paragraph(&mut doc, "", "ghost");
        // ...as does a labelled unsupported block (Table is ignored in MVP 0).
        let mut table_attrs = AttrMap::new();
        table_attrs.insert("label".to_owned(), AttrValue::Str("phantom".to_owned()));
        doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Table,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(table_attrs),
        );
        // ...then a normal labelled paragraph that does.
        make_labelled_paragraph(&mut doc, "real text", "real");

        let result = LayoutEngine::new().layout(&doc);
        // No-content labels must not leak onto a later block's page: they are
        // simply absent. Only the real paragraph maps, to its own page.
        assert!(!result.label_pages.contains_key("ghost"));
        assert!(!result.label_pages.contains_key("phantom"));
        assert_eq!(result.label_pages.get("real").copied(), Some(1));
        assert_eq!(result.label_pages.len(), 1);
    }

    fn make_numbered_section(doc: &mut Document, level: i64, number: &str, text: &str) -> NodeId {
        let mut attrs = AttrMap::new();
        attrs.insert("level".to_owned(), AttrValue::Int(level));
        attrs.insert("number".to_owned(), AttrValue::Str(number.to_owned()));
        let id = doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Section,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        alloc_inline(doc, id, NodeKind::Text, text);
        id
    }

    #[test]
    fn outline_captures_headings_in_document_order() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_numbered_section(&mut doc, 1, "1", "Alpha");
        make_numbered_section(&mut doc, 2, "1.1", "Beta");
        make_numbered_section(&mut doc, 3, "1.1.1", "Gamma");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);

        let outline = &result.graph.outline;
        assert_eq!(outline.len(), 3, "expected 3 entries, got {outline:?}");
        assert_eq!(
            outline.iter().map(|e| e.level).collect::<Vec<_>>(),
            vec![1, 2, 3],
        );
        assert_eq!(
            outline.iter().map(|e| e.title.as_str()).collect::<Vec<_>>(),
            vec!["1 Alpha", "1.1 Beta", "1.1.1 Gamma"],
        );
        // All three headings sit on page 1, in top-to-bottom document
        // order: page_index non-decreasing, glyph tops strictly ascending.
        for pair in outline.windows(2) {
            assert!(
                pair[1].page_index >= pair[0].page_index,
                "page_index went backwards: {outline:?}"
            );
            assert!(
                pair[1].top_from_top_pt > pair[0].top_from_top_pt,
                "positions not ascending: {outline:?}"
            );
        }
    }

    #[test]
    fn outline_title_includes_section_number() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_numbered_section(&mut doc, 1, "1", "Foo");
        let result = LayoutEngine::new().layout(&doc);
        let outline = &result.graph.outline;
        assert_eq!(outline.len(), 1);
        assert_eq!(outline[0].title, "1 Foo");
        // The bookmark title uses a bare number with no trailing dot,
        // distinct from the rendered "1." run in the page stream.
        assert!(
            !outline[0].title.ends_with('.'),
            "bookmark title must not carry the render-only trailing dot"
        );
    }

    #[test]
    fn heading_across_page_break_binds_start_page() {
        // Fill page 1 with a long paragraph, then a heading. The heading
        // must bind to the page its first line actually lands on
        // (post-break), mirroring label_pages semantics — never page 1.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        let mut filler = String::new();
        for i in 0..1500 {
            let _ = write!(filler, "word{i} ");
        }
        make_paragraph(&mut doc, filler.trim());
        make_numbered_section(&mut doc, 1, "2", "ZZLATER");

        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.graph.pages.len() >= 2,
            "expected a multi-page layout"
        );

        let outline = &result.graph.outline;
        assert_eq!(outline.len(), 1, "expected one heading entry");
        // Cross-check against the page whose runs actually contain the
        // heading text; page_index is 0-based, page.number is 1-based.
        let landing = result
            .graph
            .pages
            .iter()
            .find(|page| page.runs.iter().any(|run| run.text == "ZZLATER"))
            .map(|page| page.number)
            .expect("heading run must exist on some page");
        assert_eq!(
            outline[0].page_index,
            usize::try_from(landing - 1).unwrap_or(0)
        );
        assert!(
            outline[0].page_index >= 1,
            "heading after a full page must not bind to page 1"
        );
    }

    #[test]
    fn document_without_headings_has_empty_outline() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "just a paragraph");
        make_paragraph(&mut doc, "another one");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.graph.outline.is_empty(),
            "heading-free doc must have no outline: {:?}",
            result.graph.outline
        );
    }

    #[test]
    fn empty_heading_produces_no_outline_entry() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        // A section with no inline text emits no glyphs and no bookmark.
        make_section(&mut doc, 1, "");
        // A real paragraph ensures the page still has content, so the
        // absence of an entry is about the empty heading specifically.
        make_paragraph(&mut doc, "body");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.graph.outline.is_empty(),
            "empty heading must not create an outline entry: {:?}",
            result.graph.outline
        );
    }

    #[test]
    fn emphasis_run_uses_oblique() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_paragraph(&mut doc, "before");
        alloc_inline(&mut doc, para, NodeKind::Emphasis, "italic");
        alloc_inline(&mut doc, para, NodeKind::Text, "after");
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        let italic = runs
            .iter()
            .find(|r| r.text == "italic")
            .expect("italic run");
        assert!(matches!(
            italic.font,
            Font::Base14(Base14Font::HelveticaOblique)
        ));
    }

    #[test]
    fn bold_italic_run_uses_bold_oblique() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_paragraph(&mut doc, "before");
        alloc_inline(&mut doc, para, NodeKind::BoldItalic, "both");
        alloc_inline(&mut doc, para, NodeKind::Text, "after");
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        let both = runs
            .iter()
            .find(|r| r.text == "both")
            .expect("bold-italic run");
        assert!(matches!(
            both.font,
            Font::Base14(Base14Font::HelveticaBoldOblique)
        ));
    }

    #[test]
    fn styled_and_code_punctuation_do_not_get_synthetic_glue() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "See ");
        alloc_inline(&mut doc, para, NodeKind::Strong, "bold");
        alloc_inline(&mut doc, para, NodeKind::Text, ". ");
        alloc_inline(&mut doc, para, NodeKind::Emphasis, "italic");
        alloc_inline(&mut doc, para, NodeKind::Text, ", ");
        alloc_inline(&mut doc, para, NodeKind::Raw, "code");
        alloc_inline(&mut doc, para, NodeKind::Text, "?");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_runs_touch(run_text(runs, "bold"), run_text(runs, "."));
        assert_runs_touch(run_text(runs, "italic"), run_text(runs, ","));
        assert_runs_touch(run_text(runs, "code"), run_text(runs, "?"));
    }

    #[test]
    fn references_citations_and_brackets_do_not_get_synthetic_glue() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "See ");
        alloc_inline(&mut doc, para, NodeKind::Reference, "1.2");
        alloc_inline(&mut doc, para, NodeKind::Text, ", ");
        alloc_inline(&mut doc, para, NodeKind::Citation, "[1]");
        alloc_inline(&mut doc, para, NodeKind::Text, ". (");
        alloc_inline(&mut doc, para, NodeKind::Strong, "bold");
        alloc_inline(&mut doc, para, NodeKind::Text, ") [");
        alloc_inline(&mut doc, para, NodeKind::Emphasis, "italic");
        alloc_inline(&mut doc, para, NodeKind::Text, "]");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_runs_touch(run_text(runs, "1.2"), run_text(runs, ","));
        assert_runs_touch(run_text(runs, "[1]"), run_text(runs, "."));
        assert_runs_touch(run_text(runs, "("), run_text(runs, "bold"));
        assert_runs_touch(run_text(runs, "bold"), run_text(runs, ")"));
        assert_runs_touch(run_text(runs, "["), run_text(runs, "italic"));
        assert_runs_touch(run_text(runs, "italic"), run_text(runs, "]"));
    }

    #[test]
    fn leading_and_trailing_ascii_whitespace_do_not_emit_empty_runs() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        make_paragraph(&mut doc, " \n\t foo  \n");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(
            runs.iter().map(|r| r.text.as_str()).collect::<Vec<_>>(),
            vec!["foo"],
            "got {runs:?}"
        );
    }

    #[test]
    fn multiple_ascii_whitespace_runs_collapse_to_one_glue() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        make_paragraph(&mut doc, "foo  \n\t  bar");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let foo = run_text(runs, "foo");
        let bar = run_text(runs, "bar");
        let foo_w = text_width(foo.font, foo.size_pt, "foo");
        let space_w = text_width(foo.font, foo.size_pt, " ");
        let gap = bar.x_pt - (foo.x_pt + foo_w);
        assert!(
            (gap - space_w).abs() < 0.01,
            "expected one collapsed space ({space_w:.3}pt), got {gap:.3}pt"
        );
    }

    #[test]
    fn punctuation_without_source_space_does_not_wrap_alone() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let font = Font::Base14(Base14Font::Helvetica);
        let bold = Font::Base14(Base14Font::HelveticaBold);
        let target =
            text_width(bold, BODY_SIZE_PT, "word") + text_width(font, BODY_SIZE_PT, ".") + 0.5;
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - target) / 2.0);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "lead ");
        alloc_inline(&mut doc, para, NodeKind::Strong, "word");
        alloc_inline(&mut doc, para, NodeKind::Text, ".");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let lead = run_text(runs, "lead");
        let word = run_text(runs, "word");
        let dot = run_text(runs, ".");
        assert!(word.baseline_from_top_pt > lead.baseline_from_top_pt);
        assert_runs_touch(word, dot);
    }

    #[test]
    fn source_line_wrap_before_closing_punctuation_does_not_create_glue() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Strong, "κόσμε");
        alloc_inline(&mut doc, para, NodeKind::Text, "\n. None");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_runs_touch(run_text(runs, "κόσμε"), run_text(runs, "."));
    }

    #[test]
    fn hard_break_after_pending_source_space_drops_that_space() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "foo ");
        alloc_hardbreak(&mut doc, para);
        alloc_inline(&mut doc, para, NodeKind::Text, "bar");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let foo = run_text(runs, "foo");
        let bar = run_text(runs, "bar");
        assert!((foo.x_pt - bar.x_pt).abs() < 0.01, "got {runs:?}");
        assert!(bar.baseline_from_top_pt > foo.baseline_from_top_pt);
    }

    #[test]
    fn runs_stay_within_horizontal_margins() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(
            &mut doc,
            "the quick brown fox jumps over the lazy dog the quick brown fox",
        );
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        assert!(!runs.is_empty());
        let right = A4_WIDTH_PT - MARGIN_PT;
        for run in runs {
            assert!(run.x_pt >= MARGIN_PT - 1e-6, "x={}", run.x_pt);
            let end = run.x_pt + text_width(run.font, run.size_pt, &run.text);
            assert!(end <= right + 1e-3, "end={end} right={right}");
        }
    }

    #[test]
    fn cyrillic_flows_through_embedded_default_without_substitution() {
        // The default text family is bundled Noto Sans, which covers
        // Cyrillic. The run carries the original UTF-8 text verbatim
        // and a non-empty shaped glyph stream; no substitution diagnostic (the warning
        // is retired) and no `?` substitution.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "Привет");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.diagnostics.is_empty(),
            "expected no diagnostics, got {:?}",
            result.diagnostics
        );
        let runs = &result.graph.pages[0].runs;
        let cyr = runs.iter().find(|r| r.text == "Привет").expect("cyr run");
        assert!(matches!(cyr.font, Font::Embedded(_)));
        assert!(!cyr.glyphs.is_empty(), "expected shaped glyphs");
    }

    #[test]
    fn decomposed_text_is_normalized_before_shaping() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "S\u{0326}");

        let result = LayoutEngine::new().layout(&doc);

        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let run = result.graph.pages[0]
            .runs
            .iter()
            .find(|r| r.text == "\u{0218}")
            .expect("normalized run");
        assert!(matches!(run.font, Font::Embedded(_)));
        assert!(!run.glyphs.is_empty(), "expected shaped glyphs");
    }

    #[test]
    fn extended_latin_passes_through_without_warning() {
        // Polish + Czech: every char is either a WinAnsi native
        // (`ó`, `r`, `i`, …) or an extended glyph reachable via
        // `extended_glyph_name` (`ł`, `Ł`, `ě`, `ř`; `ž` is WinAnsi at 0x9E).
        // No substitution, no diagnostic.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "Łódź — Příliš");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.diagnostics.is_empty(),
            "expected no diagnostics, got {:?}",
            result.diagnostics
        );
        let text: String = result.graph.pages[0]
            .runs
            .iter()
            .map(|r| r.text.as_str())
            .collect::<Vec<_>>()
            .join(" ");
        assert!(text.contains("Łódź"), "got {text}");
        assert!(text.contains("Příliš"), "got {text}");
    }

    #[test]
    fn cjk_and_emoji_flow_through_without_diagnostics() {
        // The substitution warning is retired. CJK and emoji are not covered by bundled
        // Noto Sans Regular either, but the layout engine no longer
        // filters them: they pass through to the shaped glyph stream
        // (rustybuzz emits `.notdef` glyphs for missing coverage,
        // which the PDF backend embeds harmlessly).
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "日本語 🦀");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.diagnostics.is_empty(),
            "uncovered glyphs should flow through without a diagnostic, got {:?}",
            result.diagnostics
        );
    }

    #[test]
    fn winansi_chars_pass_through_without_warning() {
        // café / §1 / Straße all live in WinAnsi (Latin-1 + section
        // sign + germandbls). No substitution, no diagnostic.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_paragraph(&mut doc, "café §1 Straße");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.diagnostics.is_empty(),
            "expected no diagnostics, got {:?}",
            result.diagnostics
        );
        let text: String = result.graph.pages[0]
            .runs
            .iter()
            .map(|r| r.text.as_str())
            .collect::<Vec<_>>()
            .join(" ");
        assert!(text.contains("café"), "got {text}");
        assert!(text.contains("Straße"), "got {text}");
    }

    #[test]
    fn empty_document_emits_one_blank_page() {
        let doc = Document::new(PathBuf::from("test.mos"));
        let result = LayoutEngine::new().layout(&doc);
        assert_eq!(result.graph.pages.len(), 1);
        assert!(result.graph.pages[0].runs.is_empty());
    }

    #[test]
    fn raw_inline_uses_courier() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_paragraph(&mut doc, "before");
        alloc_inline(&mut doc, para, NodeKind::Raw, "code");
        alloc_inline(&mut doc, para, NodeKind::Text, "after");
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        let code_run = runs.iter().find(|r| r.text == "code").expect("code run");
        assert!(matches!(code_run.font, Font::Base14(Base14Font::Courier)));
        // Adjacent runs stay in the default Helvetica face so the
        // engine isn't accidentally promoting everything to Courier.
        assert!(matches!(
            runs.iter().find(|r| r.text == "before").unwrap().font,
            Font::Base14(Base14Font::Helvetica)
        ));
    }

    #[test]
    fn raw_block_tabs_render_as_spaces() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_raw_block(&mut doc, "\tprintln(\"hello\");");

        let result = LayoutEngine::new().layout(&doc);

        let rendered = result.graph.pages[0]
            .runs
            .iter()
            .map(|run| run.text.as_str())
            .collect::<String>();
        assert!(
            !rendered.contains('\t'),
            "raw block tabs should be expanded before shaping: {rendered:?}"
        );
        assert!(
            rendered.contains("    println"),
            "expected four-space tab expansion, got {rendered:?}"
        );
        assert!(
            result.graph.pages[0]
                .runs
                .iter()
                .any(|run| run.actual_text.as_deref() == Some("\tprintln(\"hello\");")),
            "raw block tabs should retain their original text for extraction"
        );
    }

    #[test]
    fn raw_block_leading_blank_line_preserves_spacing() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_raw_block(&mut doc, "\ncode");

        let result = LayoutEngine::new().layout(&doc);

        let first_run = result.graph.pages[0]
            .runs
            .first()
            .expect("raw block should emit text after the leading blank");
        let expected_baseline = BODY_SIZE_PT.mul_add(
            BODY_LEADING,
            MARGIN_PT + ascent(FontFamily::noto_sans().monospace, BODY_SIZE_PT),
        );
        assert!(
            (first_run.baseline_from_top_pt - expected_baseline).abs() < 0.01,
            "baseline {}, expected {expected_baseline}",
            first_run.baseline_from_top_pt
        );
    }

    #[test]
    fn heading_levels_pick_distinct_sizes() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        make_section(&mut doc, 1, "H1");
        make_section(&mut doc, 2, "H2");
        make_section(&mut doc, 3, "H3");
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        let h1 = runs.iter().find(|r| r.text == "H1").expect("H1 run");
        let h2 = runs.iter().find(|r| r.text == "H2").expect("H2 run");
        let h3 = runs.iter().find(|r| r.text == "H3").expect("H3 run");
        assert!((h1.size_pt - HEADING_SIZES_PT[0]).abs() < f32::EPSILON);
        assert!((h2.size_pt - HEADING_SIZES_PT[1]).abs() < f32::EPSILON);
        assert!((h3.size_pt - HEADING_SIZES_PT[2]).abs() < f32::EPSILON);
        // Each level is strictly smaller than the one above it.
        assert!(h1.size_pt > h2.size_pt);
        assert!(h2.size_pt > h3.size_pt);
        // Vertical order matches source order.
        assert!(h1.baseline_from_top_pt < h2.baseline_from_top_pt);
        assert!(h2.baseline_from_top_pt < h3.baseline_from_top_pt);
    }

    #[test]
    fn heading_after_long_paragraph_paginates_correctly() {
        // A paragraph long enough to span multiple pages, followed
        // by a heading. The heading must appear *after* every
        // paragraph word in document order, and the first paragraph
        // word and the heading must end up on different pages.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let mut text = String::new();
        for i in 0..1500 {
            let _ = write!(text, "word{i} ");
        }
        make_paragraph(&mut doc, text.trim());
        make_section(&mut doc, 1, "After");
        let result = LayoutEngine::new().layout(&doc);
        assert!(
            result.graph.pages.len() >= 2,
            "expected pagination, got {} page(s)",
            result.graph.pages.len()
        );
        // Locate the heading and the very first paragraph word.
        let mut heading_page: Option<u32> = None;
        let mut first_word_page: Option<u32> = None;
        for page in &result.graph.pages {
            for run in &page.runs {
                if run.text == "After"
                    && matches!(run.font, Font::Base14(Base14Font::HelveticaBold))
                {
                    heading_page = Some(page.number);
                }
                if run.text == "word0" && first_word_page.is_none() {
                    first_word_page = Some(page.number);
                }
            }
        }
        let heading_page = heading_page.expect("heading run not emitted");
        let first_word_page = first_word_page.expect("first paragraph word not emitted");
        assert!(
            heading_page > first_word_page,
            "heading on page {heading_page}, first paragraph word on page {first_word_page}"
        );
    }

    #[test]
    fn heading_with_number_attribute_emits_prefix_run() {
        // Resolver writes `number = "2.1"` onto a section node; layout
        // must emit a leading bold run with that number plus a trailing
        // dot, ahead of the heading text.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let mut attrs = AttrMap::new();
        attrs.insert("level".to_owned(), AttrValue::Int(2));
        attrs.insert("number".to_owned(), AttrValue::Str("2.1".to_owned()));
        let section = doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Section,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        alloc_inline(&mut doc, section, NodeKind::Text, "Background");
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        assert!(matches!(
            runs[0].font,
            Font::Base14(Base14Font::HelveticaBold)
        ));
        assert_eq!(runs[0].text, "2.1.");
        assert!(runs.iter().any(|r| r.text == "Background"));
        // The number's baseline matches the title's baseline because
        // they live on the same line.
        let title = runs.iter().find(|r| r.text == "Background").unwrap();
        assert!((runs[0].baseline_from_top_pt - title.baseline_from_top_pt).abs() < 1e-3);
    }

    #[test]
    fn numbered_heading_prefix_and_title_have_one_space_gap() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let mut attrs = AttrMap::new();
        attrs.insert("level".to_owned(), AttrValue::Int(2));
        attrs.insert("number".to_owned(), AttrValue::Str("2.1".to_owned()));
        let section = doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Section,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        alloc_inline(&mut doc, section, NodeKind::Text, "Background");

        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        let prefix = run_text(runs, "2.1.");
        let title = run_text(runs, "Background");
        let prefix_w = text_width(prefix.font, prefix.size_pt, &prefix.text);
        let expected_gap = text_width(prefix.font, prefix.size_pt, " ");
        let gap = title.x_pt - (prefix.x_pt + prefix_w);
        assert!(
            (gap - expected_gap).abs() < 0.01,
            "expected one heading space ({expected_gap:.3}pt), got {gap:.3}pt"
        );
    }

    #[test]
    fn reference_node_renders_resolved_text() {
        // A `Reference` node with a `text` attribute (set by the
        // resolver) flows through `collect_words` like any other inline
        //; no separate code path. The font defaults to the body face.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_paragraph(&mut doc, "see");
        let mut attrs = AttrMap::new();
        attrs.insert("label".to_owned(), AttrValue::Str("intro".to_owned()));
        attrs.insert("text".to_owned(), AttrValue::Str("1.2".to_owned()));
        doc.alloc_child(
            para,
            NodeSpec::new(
                NodeKind::Reference,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        let reference = runs.iter().find(|r| r.text == "1.2").expect("ref run");
        assert!(matches!(
            reference.font,
            Font::Base14(Base14Font::Helvetica)
        ));
    }

    // ---------- line-break controls (issue #26) ----------

    fn alloc_hardbreak(doc: &mut Document, parent: NodeId) {
        // HardBreak nodes carry no attributes -- layout dispatches on
        // `NodeKind` alone (see `collect_words`).
        doc.alloc_child(
            parent,
            NodeSpec::new(
                NodeKind::HardBreak,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            ),
        );
    }

    fn make_empty_paragraph(doc: &mut Document) -> NodeId {
        doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Paragraph,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            ),
        )
    }

    #[test]
    fn nbsp_keeps_two_words_in_a_single_run() {
        // U+00A0 is *not* ASCII whitespace, so the greedy breaker
        // never splits at it. The two halves end up as one TextRun
        // with the NBSP byte preserved -- the documented contract.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        make_paragraph(&mut doc, "Mr.\u{A0}Smith");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(runs.len(), 1, "expected one TextRun, got {runs:?}");
        assert_eq!(runs[0].text, "Mr.\u{A0}Smith");
    }

    #[test]
    fn hard_break_advances_one_line_not_paragraph_spacing() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "foo");
        alloc_hardbreak(&mut doc, para);
        alloc_inline(&mut doc, para, NodeKind::Text, "bar");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let foo = runs.iter().find(|r| r.text == "foo").expect("foo run");
        let bar = runs.iter().find(|r| r.text == "bar").expect("bar run");
        let delta = bar.baseline_from_top_pt - foo.baseline_from_top_pt;
        // BODY_SIZE_PT × default leading is the inter-line distance;
        // accept either 1.0 or the resolved style's default leading
        // by checking against the computed product.
        let expected = BODY_SIZE_PT * BODY_LEADING;
        assert!(
            (delta - expected).abs() < 0.01,
            "expected inter-line delta {expected}, got {delta} (foo={}, bar={})",
            foo.baseline_from_top_pt,
            bar.baseline_from_top_pt
        );
    }

    #[test]
    fn two_hard_breaks_produce_a_blank_line() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "foo");
        alloc_hardbreak(&mut doc, para);
        alloc_hardbreak(&mut doc, para);
        alloc_inline(&mut doc, para, NodeKind::Text, "bar");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let foo = runs.iter().find(|r| r.text == "foo").expect("foo run");
        let bar = runs.iter().find(|r| r.text == "bar").expect("bar run");
        let delta = bar.baseline_from_top_pt - foo.baseline_from_top_pt;
        // Two line advances: one to flush "foo", one for the blank
        // line between the two hard breaks.
        let one_line = BODY_SIZE_PT * BODY_LEADING;
        let expected = 2.0 * one_line;
        assert!(
            (delta - expected).abs() < 0.01,
            "expected delta {expected} for two-line gap, got {delta}"
        );
    }

    #[test]
    fn hard_break_at_paragraph_start_collapses_on_first_page_line() {
        // When the paragraph begins with a hard break and nothing is
        // on the page yet, the leading break has nothing above it to
        // push down -- it collapses, matching CommonMark's "ignore
        // hard break at block boundary".
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        alloc_hardbreak(&mut doc, para);
        alloc_inline(&mut doc, para, NodeKind::Text, "foo");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(runs.len(), 1, "expected one run, got {runs:?}");
        assert_eq!(runs[0].text, "foo");
    }

    #[test]
    fn hard_break_after_oversize_word_does_not_add_blank_line() {
        // Regression: an oversize word emits chunks via
        // `flush_oversize_word`, which implicitly ends the line. A
        // following hard break used to add *another* line on top of
        // that implicit end. The break should now be absorbed so
        // `oversize\\next` produces `next` on the immediate next
        // line, not a blank-then-next.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let para = make_empty_paragraph(&mut doc);
        // A 500-char run of `a` is certainly wider than the default A4
        // column; the layout chops it into oversize chunks.
        let huge: String = "a".repeat(500);
        alloc_inline(&mut doc, para, NodeKind::Text, &huge);
        alloc_hardbreak(&mut doc, para);
        alloc_inline(&mut doc, para, NodeKind::Text, "next");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let next = runs.iter().find(|r| r.text == "next").expect("next run");
        // The last oversize chunk is the run whose text is all `a`s
        // and whose baseline is the highest among `a`-only runs.
        let last_chunk_baseline = runs
            .iter()
            .filter(|r| !r.text.is_empty() && r.text.chars().all(|c| c == 'a'))
            .map(|r| r.baseline_from_top_pt)
            .fold(f32::NEG_INFINITY, f32::max);
        assert!(
            last_chunk_baseline.is_finite(),
            "did not find any oversize-chunk runs"
        );
        let one_line = BODY_SIZE_PT * BODY_LEADING;
        let delta = next.baseline_from_top_pt - last_chunk_baseline;
        assert!(
            (delta - one_line).abs() < 0.01,
            "expected one-line gap ({one_line:.3}pt) between last oversize chunk and `next`, got {delta:.3}pt -- hard break emitted extra blank?"
        );
    }

    #[test]
    fn leading_hard_break_collapses_after_prior_page_content() {
        // A hard break at the start of a paragraph must collapse even
        // when prior paragraphs have painted on the page -- the rule
        // is block-boundary, not page-state. Compare against a control
        // doc whose second paragraph has no leading hard break: the
        // two layouts must agree on the vertical position of `second`.
        let layout_one = |with_leading_break: bool| {
            let mut doc = Document::new(PathBuf::from("test.mos"));
            pin_helvetica(&mut doc);
            make_paragraph(&mut doc, "first");
            let p2 = make_empty_paragraph(&mut doc);
            if with_leading_break {
                alloc_hardbreak(&mut doc, p2);
            }
            alloc_inline(&mut doc, p2, NodeKind::Text, "second");
            LayoutEngine::new().layout(&doc).graph.pages[0]
                .runs
                .iter()
                .find(|r| r.text == "second")
                .expect("second run")
                .baseline_from_top_pt
        };
        let actual = layout_one(true);
        let control = layout_one(false);
        assert!(
            (actual - control).abs() < 0.01,
            "leading hard break should collapse: control baseline {control:.3}pt, got {actual:.3}pt"
        );
    }

    #[test]
    fn shy_only_piece_does_not_emit_phantom_word() {
        // A whitespace-delimited piece consisting entirely of SHY
        // codepoints strips to empty -- skip it rather than emit a
        // zero-width Word, which would push an extra space gap into
        // the line because flush_line charges one space-advance per
        // word past the first.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        // Three pieces after ASCII-whitespace split: "foo", "\u{AD}\u{AD}", "bar".
        // The middle piece must produce zero Word items.
        make_paragraph(&mut doc, "foo \u{AD}\u{AD} bar");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(
            runs.iter().map(|r| r.text.as_str()).collect::<Vec<_>>(),
            vec!["foo", "bar"],
            "got {runs:?}"
        );
        let foo_w = text_width(runs[0].font, runs[0].size_pt, "foo");
        let space_w = text_width(runs[0].font, runs[0].size_pt, " ");
        let gap = runs[1].x_pt - (runs[0].x_pt + foo_w);
        assert!(
            (gap - space_w).abs() < 0.01,
            "expected one space gap ({space_w:.3}pt), got {gap:.3}pt -- phantom SHY-only word?"
        );
    }

    #[test]
    fn soft_hyphen_is_stripped_from_emitted_runs() {
        // SHY codepoints must never appear in the rendered text --
        // when the word fits, the greedy breaker leaves it alone and
        // no visible hyphen is emitted.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        make_paragraph(&mut doc, "super\u{AD}cali\u{AD}fragil");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(runs.len(), 1, "expected one run, got {runs:?}");
        assert_eq!(runs[0].text, "supercalifragil");
        assert!(
            !runs[0].text.contains('\u{AD}'),
            "SHY leaked into rendered text: {:?}",
            runs[0].text
        );
    }

    /// Insert a `#set page(margin: <pt>)` block so the column is
    /// narrow enough to force soft-hyphen breaks in subsequent
    /// paragraphs. Mirrors the helper in `style.rs`.
    fn pin_narrow_margin(doc: &mut Document, margin_pt: f32) {
        let mut attrs = AttrMap::new();
        attrs.insert("set".to_owned(), AttrValue::Str("page".to_owned()));
        attrs.insert(
            "set.arg.margin".to_owned(),
            AttrValue::Length(f64::from(margin_pt)),
        );
        doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Raw,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
    }

    #[test]
    fn shy_only_styled_child_preserves_break_opportunity() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let font = Font::Base14(Base14Font::Helvetica);
        let target = text_width(font, BODY_SIZE_PT, "foo-") + 0.5;
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - target) / 2.0);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "foo");
        alloc_inline(&mut doc, para, NodeKind::Emphasis, "\u{AD}");
        alloc_inline(&mut doc, para, NodeKind::Text, "bar");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(
            runs.iter().map(|r| r.text.as_str()).collect::<Vec<_>>(),
            vec!["foo-", "bar"],
            "got {runs:?}"
        );
        assert!(
            run_text(runs, "bar").baseline_from_top_pt
                > run_text(runs, "foo-").baseline_from_top_pt
        );
    }

    #[test]
    fn styled_soft_hyphen_split_preserves_subrun_fonts() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let regular = Font::Base14(Base14Font::Helvetica);
        let bold = Font::Base14(Base14Font::HelveticaBold);
        let target =
            text_width(regular, BODY_SIZE_PT, "pre") + text_width(bold, BODY_SIZE_PT, "su-") + 0.5;
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - target) / 2.0);
        let para = make_empty_paragraph(&mut doc);
        alloc_inline(&mut doc, para, NodeKind::Text, "pre");
        alloc_inline(&mut doc, para, NodeKind::Strong, "su\u{AD}per");

        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(
            runs.iter().map(|r| r.text.as_str()).collect::<Vec<_>>(),
            vec!["pre", "su-", "per"],
            "got {runs:?}"
        );
        assert!(matches!(
            run_text(runs, "pre").font,
            Font::Base14(Base14Font::Helvetica)
        ));
        assert!(matches!(
            run_text(runs, "su-").font,
            Font::Base14(Base14Font::HelveticaBold)
        ));
        assert!(matches!(
            run_text(runs, "per").font,
            Font::Base14(Base14Font::HelveticaBold)
        ));
        assert_runs_touch(run_text(runs, "pre"), run_text(runs, "su-"));
        assert!(
            run_text(runs, "per").baseline_from_top_pt > run_text(runs, "su-").baseline_from_top_pt
        );
    }

    #[test]
    fn shy_breaks_word_when_line_overflows() {
        // `su\u{AD}per` on a column narrow enough that "super"
        // overflows but "su-" fits. The greedy breaker must split
        // at the SHY offset, render "su-" on the first line, and
        // continue with "per" on the second.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        // Column ≈ 25pt (just over `su-` at 12pt Helvetica, under
        // the full `super`).
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - 25.0) / 2.0);
        make_paragraph(&mut doc, "su\u{AD}per");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let texts: Vec<&str> = runs.iter().map(|r| r.text.as_str()).collect();
        assert_eq!(texts, vec!["su-", "per"], "got {runs:?}");
        assert!(runs[1].baseline_from_top_pt > runs[0].baseline_from_top_pt);
        for r in runs {
            assert!(
                !r.text.contains('\u{AD}'),
                "SHY leaked into rendered text: {:?}",
                r.text
            );
        }
    }

    #[test]
    fn shy_picks_latest_fitting_break() {
        // Two SHYs in `super\u{AD}cali\u{AD}fragil` (offsets 5, 9).
        // Column wide enough for "supercali-" but not the full word
        // must pick the latest fitting offset (9), not the earliest.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let font = Font::Base14(Base14Font::Helvetica);
        let target = text_width(font, BODY_SIZE_PT, "supercali-") + 2.0;
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - target) / 2.0);
        make_paragraph(&mut doc, "super\u{AD}cali\u{AD}fragil");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        let texts: Vec<&str> = runs.iter().map(|r| r.text.as_str()).collect();
        assert_eq!(texts, vec!["supercali-", "fragil"], "got {runs:?}");
    }

    #[test]
    fn shy_at_zero_or_end_offset_is_ignored() {
        // `\u{AD}foo\u{AD}` strips to "foo" with offsets [0, 3] --
        // both are boundary positions and must be ignored. With a
        // column too narrow for "foo" the SHY path returns None and
        // the existing oversize-cluster fallback fires; no bare
        // leading or trailing hyphen appears.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let font = Font::Base14(Base14Font::Helvetica);
        // Narrower than "foo" so the column can't hold it whole.
        let target = text_width(font, BODY_SIZE_PT, "fo");
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - target) / 2.0);
        make_paragraph(&mut doc, "\u{AD}foo\u{AD}");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        // Boundary SHYs ignored: no run is just "-" and no run
        // ends with "-" (that would mean a SHY break was taken).
        for r in runs {
            assert_ne!(r.text, "-", "bare hyphen run from boundary SHY");
            assert!(
                !r.text.ends_with('-'),
                "trailing hyphen from boundary SHY: {:?}",
                r.text
            );
        }
        let joined: String = runs.iter().map(|r| r.text.as_str()).collect();
        assert_eq!(joined, "foo", "all clusters together still spell foo");
    }

    #[test]
    fn shy_falls_back_to_oversize_when_no_break_fits() {
        // Column so narrow that neither prefix at the SHY offset
        // ("super-" nor "supercali-") fits. The breaker falls
        // through to `flush_oversize_word`, which chops by
        // shaped clusters -- no SHY-driven `-` appears.
        let mut doc = Document::new(PathBuf::from("test.mos"));
        pin_helvetica(&mut doc);
        let font = Font::Base14(Base14Font::Helvetica);
        // Narrower than even "su-": forces every candidate to fail.
        let target = text_width(font, BODY_SIZE_PT, "s") + 0.5;
        pin_narrow_margin(&mut doc, (A4_WIDTH_PT - target) / 2.0);
        make_paragraph(&mut doc, "super\u{AD}cali");
        let result = LayoutEngine::new().layout(&doc);
        assert!(result.diagnostics.is_empty(), "{:?}", result.diagnostics);
        let runs = &result.graph.pages[0].runs;
        // Cluster fallback emits single-character runs; none of
        // them end with `-` (the source has no `-` and the SHY
        // path never fired).
        for r in runs {
            assert!(
                !r.text.ends_with('-'),
                "oversize fallback emitted hyphen: {:?}",
                r.text
            );
        }
        let joined: String = runs.iter().map(|r| r.text.as_str()).collect();
        assert_eq!(joined, "supercali");
    }

    #[test]
    fn set_blocks_are_skipped() {
        let mut doc = Document::new(PathBuf::from("test.mos"));
        let mut attrs = AttrMap::new();
        attrs.insert("set".to_owned(), AttrValue::Str("page".to_owned()));
        doc.alloc_child(
            doc.root,
            NodeSpec::new(
                NodeKind::Raw,
                SourceSpan::placeholder(PathBuf::from("test.mos")),
            )
            .with_attributes(attrs),
        );
        make_paragraph(&mut doc, "body");
        let result = LayoutEngine::new().layout(&doc);
        let runs = &result.graph.pages[0].runs;
        assert_eq!(runs.len(), 1);
        assert_eq!(runs[0].text, "body");
    }
}